feat(Calendar): use outlined buttons view in case of xl size #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MefistAldemisov requested review from ValeraS, amje and korvin89 as code owners 
| Preview is ready. |
korvin89 reviewed Aug 18, 2025
| state, | ||
| ); | ||
| | ||
| const buttonView = props.size === 'xl' ? 'outlined' : 'flat'; |
There was a problem hiding this comment.
Why we should change button view according to the size property? I suggest u to use useMobile hook here
korvin89 requested changes Sep 15, 2025
| $block: '.#{variables.$ns}calendar'; | ||
| | ||
| #{$block} { | ||
| --_--calendar-padding: var(--g-date-calendar-padding, 8px); |
There was a problem hiding this comment.
--g-date-calendar-padding is public css variable. Removing it is a breaking change
| #{$block} { | ||
| --_--calendar-padding: var(--g-date-calendar-padding, 8px); | ||
| --_--calendar-padding-x: var(--g-date-calendar-padding-x, 16px); | ||
| --_--calendar-padding-y: var(--g-date-calendar-padding-y, 8px); |
There was a problem hiding this comment.
Why did you need to define these variables --g-date-calendar-padding-x & --g-date-calendar-padding-y?
korvin89 changed the title korvin89 approved these changes Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Slightly tunned the design of the component:
xlsizes, because there is no focus in mobile version