Skip to content

Bugfix for SDL check if an Interface is implemented correctly #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2022
Merged

Bugfix for SDL check if an Interface is implemented correctly #3014

merged 1 commit into from
Nov 11, 2022

Conversation

@andimarek
Copy link
Member

Applied directives on arguments are not relevant when checked if an interface is implemented correctly.

For example this SDL should be valid, but it was rejected:

directive @d on ARGUMENT_DEFINITION type Query implements I { foo(arg: String @d): String } interface I { foo(arg: String): String }

This fixes this bug.
@andimarek andimarek added this to the 20.0 milestone Nov 11, 2022
@andimarek andimarek merged commit d194761 into master Nov 11, 2022
@andimarek andimarek deleted the fix-argument-directives-implementations branch November 11, 2022 22:04
bbakerman
bbakerman reviewed Nov 12, 2022
View reviewed changes
Copy link
Member

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@andimarek @bbakerman