This repository was archived by the owner on Nov 29, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork 11
feat!: migrate to microgenerator #29
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,178 @@ | ||
| # 2.0.0 Migration Guide | ||
| | ||
| The 2.0 release of the `google-cloud-scheduler` client is a significant upgrade based on a [next-gen code generator](https://github.com/googleapis/gapic-generator-python), and includes substantial interface changes. Existing code written for earlier versions of this library will likely require updates to use this version. This document describes the changes that have been made, and what you need to do to update your usage. | ||
| | ||
| If you experience issues or have questions, please file an [issue](https://github.com/googleapis/python-scheduler/issues). | ||
| | ||
| ## Supported Python Versions | ||
| | ||
| > **WARNING**: Breaking change | ||
| | ||
| The 2.0.0 release requires Python 3.6+. | ||
| | ||
| | ||
| ## Method Calls | ||
| | ||
| > **WARNING**: Breaking change | ||
| | ||
| Methods expect request objects. We provide a script that will convert most common use cases. | ||
| | ||
| * Install the library | ||
| | ||
| ```py | ||
| python3 -m pip install google-cloud-scheduler | ||
| ``` | ||
| | ||
| * The script `fixup_scheduler_{version}_keywords.py` is shipped with the library. It expects | ||
| an input directory (with the code to convert) and an empty destination directory. | ||
| | ||
| ```sh | ||
| $ fixup_scheduler_v1_keywords.py --input-directory .samples/ --output-directory samples/ | ||
| ``` | ||
| | ||
| **Before:** | ||
| ```py | ||
| from google.cloud import scheduler | ||
| | ||
| client = scheduler.CloudSchedulerClient() | ||
| | ||
| parent = client.location_path("<PROJECT_ID>", "<LOCATION>") | ||
| job = { | ||
| 'app_engine_http_target': { | ||
| 'app_engine_routing': { | ||
| 'service': service_id | ||
| }, | ||
| 'relative_uri': '/log_payload', | ||
| 'http_method': 'POST', | ||
| 'body': 'Hello World'.encode() | ||
| }, | ||
| 'schedule': '* * * * *', | ||
| 'time_zone': 'America/Los_Angeles' | ||
| } | ||
| | ||
| response = client.create_job(parent, job) | ||
| ``` | ||
| | ||
| | ||
| **After:** | ||
| ```py | ||
| from google.cloud import scheduler | ||
| | ||
| client = scheduler.CloudSchedulerClient() | ||
| parent = "projects/<PROJECT_ID>/locations/<LOCATION>" | ||
| job = { | ||
| 'app_engine_http_target': { | ||
| 'app_engine_routing': { | ||
| 'service': service_id | ||
| }, | ||
| 'relative_uri': '/log_payload', | ||
| 'http_method': 'POST', | ||
| 'body': 'Hello World'.encode() | ||
| }, | ||
| 'schedule': '* * * * *', | ||
| 'time_zone': 'America/Los_Angeles' | ||
| } | ||
| | ||
| response = client.create_job( | ||
| request={ | ||
| "parent": parent, | ||
| "job": job | ||
| } | ||
| ) | ||
| ``` | ||
| | ||
| ### More Details | ||
| | ||
| In `google-cloud-scheduler<2.0.0`, parameters required by the API were positional parameters and optional parameters were keyword parameters. | ||
| | ||
| **Before:** | ||
| ```py | ||
| def list_jobs( | ||
| self, | ||
| parent, | ||
| page_size=None, | ||
| retry=google.api_core.gapic_v1.method.DEFAULT, | ||
| timeout=google.api_core.gapic_v1.method.DEFAULT, | ||
| metadata=None, | ||
| ): | ||
| ``` | ||
| | ||
| In the 2.0.0 release, all methods have a single positional parameter `request`. Method docstrings indicate whether a parameter is required or optional. | ||
| | ||
| Some methods have additional keyword only parameters. The available parameters depend on the [`google.api.method_signature` annotation](https://github.com/googleapis/googleapis/blob/master/google/cloud/scheduler/v1/cloudscheduler.proto#L45) specified by the API producer. | ||
| | ||
| | ||
| **After:** | ||
| ```py | ||
| def list_jobs( | ||
| self, | ||
| request: cloudscheduler.ListJobsRequest = None, | ||
| *, | ||
| parent: str = None, | ||
| retry: retries.Retry = gapic_v1.method.DEFAULT, | ||
| timeout: float = None, | ||
| metadata: Sequence[Tuple[str, str]] = (), | ||
| ) -> pagers.ListJobsPager: | ||
| ``` | ||
| | ||
| > **NOTE:** The `request` parameter and flattened keyword parameters for the API are mutually exclusive. | ||
| > Passing both will result in an error. | ||
| | ||
| | ||
| Both of these calls are valid: | ||
| | ||
| ```py | ||
| response = client.list_jobs( | ||
| request={ | ||
| "parent": parent, | ||
| "timeout": timeout | ||
| } | ||
| ) | ||
| ``` | ||
| | ||
| ```py | ||
| response = client.list_jobs( | ||
| parent=parent, | ||
| timeout=timeout | ||
| ) | ||
| ``` | ||
| | ||
| This call is invalid because it mixes `request` with a keyword argument `metadata`. Executing this code | ||
| will result in an error. | ||
| | ||
| ```py | ||
| response = client.synthesize_speech( | ||
| request={ | ||
| "parent": parent, | ||
| "timeout": timeout, | ||
| }, | ||
| metadata=metadata | ||
| ) | ||
| ``` | ||
| | ||
| | ||
| | ||
| ## Enums and Types | ||
| | ||
| | ||
| > **WARNING**: Breaking change | ||
| | ||
| The submodules `enums` and `types` have been removed. | ||
| | ||
| **Before:** | ||
| ```py | ||
| | ||
| from google.cloud import scheduler | ||
| | ||
| http_method = scheduler.enums.HttpMethod.GET | ||
| job = scheduler.types.Job(name="name") | ||
| ``` | ||
| | ||
| | ||
| **After:** | ||
| ```py | ||
| from google.cloud import scheduler | ||
| | ||
| http_method = scheduler.HttpMethod.GET | ||
| job = scheduler.Job(name="name") | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../UPGRADING.md |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Services for Google Cloud Scheduler v1 API | ||
| ========================================== | ||
| | ||
| .. automodule:: google.cloud.scheduler_v1.services.cloud_scheduler | ||
| :members: | ||
| :inherited-members: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Types for Google Cloud Scheduler v1 API | ||
| ======================================= | ||
| | ||
| .. automodule:: google.cloud.scheduler_v1.types | ||
| :members: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Services for Google Cloud Scheduler v1beta1 API | ||
| =============================================== | ||
| | ||
| .. automodule:: google.cloud.scheduler_v1beta1.services.cloud_scheduler | ||
| :members: | ||
| :inherited-members: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Types for Google Cloud Scheduler v1beta1 API | ||
| ============================================ | ||
| | ||
| .. automodule:: google.cloud.scheduler_v1beta1.types | ||
| :members: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| # -*- coding: utf-8 -*- | ||
| | ||
| # Copyright 2020 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| | ||
| from google.cloud.scheduler_v1.services.cloud_scheduler.async_client import ( | ||
| CloudSchedulerAsyncClient, | ||
| ) | ||
| from google.cloud.scheduler_v1.services.cloud_scheduler.client import ( | ||
| CloudSchedulerClient, | ||
| ) | ||
| from google.cloud.scheduler_v1.types.cloudscheduler import CreateJobRequest | ||
| from google.cloud.scheduler_v1.types.cloudscheduler import DeleteJobRequest | ||
| from google.cloud.scheduler_v1.types.cloudscheduler import GetJobRequest | ||
| from google.cloud.scheduler_v1.types.cloudscheduler import ListJobsRequest | ||
| from google.cloud.scheduler_v1.types.cloudscheduler import ListJobsResponse | ||
| from google.cloud.scheduler_v1.types.cloudscheduler import PauseJobRequest | ||
| from google.cloud.scheduler_v1.types.cloudscheduler import ResumeJobRequest | ||
| from google.cloud.scheduler_v1.types.cloudscheduler import RunJobRequest | ||
| from google.cloud.scheduler_v1.types.cloudscheduler import UpdateJobRequest | ||
| from google.cloud.scheduler_v1.types.job import Job | ||
| from google.cloud.scheduler_v1.types.job import RetryConfig | ||
| from google.cloud.scheduler_v1.types.target import AppEngineHttpTarget | ||
| from google.cloud.scheduler_v1.types.target import AppEngineRouting | ||
| from google.cloud.scheduler_v1.types.target import HttpMethod | ||
| from google.cloud.scheduler_v1.types.target import HttpTarget | ||
| from google.cloud.scheduler_v1.types.target import OAuthToken | ||
| from google.cloud.scheduler_v1.types.target import OidcToken | ||
| from google.cloud.scheduler_v1.types.target import PubsubTarget | ||
| | ||
| __all__ = ( | ||
| "AppEngineHttpTarget", | ||
| "AppEngineRouting", | ||
| "CloudSchedulerAsyncClient", | ||
| "CloudSchedulerClient", | ||
| "CreateJobRequest", | ||
| "DeleteJobRequest", | ||
| "GetJobRequest", | ||
| "HttpMethod", | ||
| "HttpTarget", | ||
| "Job", | ||
| "ListJobsRequest", | ||
| "ListJobsResponse", | ||
| "OAuthToken", | ||
| "OidcToken", | ||
| "PauseJobRequest", | ||
| "PubsubTarget", | ||
| "ResumeJobRequest", | ||
| "RetryConfig", | ||
| "RunJobRequest", | ||
| "UpdateJobRequest", | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Marker file for PEP 561. | ||
| # The google-cloud-scheduler package uses inline types. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.