- Notifications
You must be signed in to change notification settings - Fork 95
chore: require Python ≥ 3.9, protobuf ≥ 4.25.8 #877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vchudnov-g wants to merge 24 commits into main Choose a base branch from py-drop-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+76 −302
Open
Changes from all commits
Commits
Show all changes
24 commits Select commit Hold shift + click to select a range
345ed00 chore: remove support for Python 3.7 and 3.8
vchudnov-g e7d5849 chore: format
vchudnov-g 00bacfc fix `nox -s prerelease_deps` by adding dependencies to noxfile
vchudnov-g d91d4b1 chore: Use async mock in async test
vchudnov-g 063991a chore: Simplify code intended for Python 3.9+
vchudnov-g e6ab415 chore: remove unused import
vchudnov-g fa50b6a chore:remove unused import; cosmetic
vchudnov-g 02bdd5d exclude coverage calculations on some exceptional lines
vchudnov-g e420f47 fix coverage: runder under proto 4.x
vchudnov-g 6c2206c test(proto-4.25.8): Fix to run on supported Python version (3.11)
vchudnov-g f9f4e7f Have nox run the legacy protobuf test
vchudnov-g cf8c92a fix coverage file names
vchudnov-g 90cff72 don't worry about covering unit test
vchudnov-g 39992e3 Cover legacy protobuf tests
vchudnov-g fb410f4 fix session skip in test
vchudnov-g 371d27e chore: require protobuf ≥ 4.25.8
vchudnov-g f9ce257 feat: warn users of upcoming minimum protobuf 5.0.0 requirement
vchudnov-g 2a57035 chore: Pin depencies to lower bounds in constraints for lowest Python…
vchudnov-g 0f9589e chore: bumpgoogleapis-common-protos to vbersion supporting protobuf 4.x
vchudnov-g f4decd5 chjore: Update minimum version of google-auth to 2.35.0
vchudnov-g c506726 chore: require requests ≥ 2.20.0
vchudnov-g 5ebe08d chore: try removing NO COVER pragmas
vchudnov-g fe43df7 restore one NO COVER pragma
vchudnov-g b1b5822 clean up removed pragmas
vchudnov-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like this comment is saying an improvement is available to us now that we're dropping 3.7. Is that something we'd want to consider, or should we stick with the existing implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at this and it didn't seem like a cleaner alternative. I'm not sure what I had in mind when I first wrote this comment, but I think the current implementation is clean.