Revert "feat: add upload functionality" #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit 7beb99d.
googlebot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #224 +/- ## ============================================ - Coverage 63.67% 63.50% -0.18% + Complexity 548 540 -8 ============================================ Files 31 30 -1 Lines 4782 4762 -20 Branches 428 427 -1 ============================================ - Hits 3045 3024 -21 - Misses 1577 1578 +1 Partials 160 160
Continue to review full report at Codecov.
|
dmitry-fa added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run 
Contributor
| @frankyn Integration test fails: com.google.cloud.storage.StorageException: The project exceeded the rate limit for creating and deleting buckets. |
frankyn added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run 
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reverts #214
Let's revert this and talk through it more before we finalize and merge again.
Once we release this change we will end with having to support it long term. I want a solution quickly but don't want to create friction.
Thank you for your patience.