fix: use core pool size 1 for maintainer #3314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The multiplexed session maintainer used a ScheduledExecutorService with a core pool size of zero. This can cause high CPU usage on Java 8 due to https://bugs.openjdk.org/browse/JDK-8129861. Also on higher versions of Java, it is better to use an executor with at least one core thread, instead of letting the executor create a new thread every time a task needs to be executed. Fixes #3313 Fixes GoogleCloudPlatform/pgadapter#2249 Fixes googleapis/java-spanner-jdbc#1736
product-auto-label bot added size: xs 
harshachinta approved these changes Aug 30, 2024
olavloite added the automerge 
gcf-merge-on-green bot removed the automerge gcf-merge-on-green bot deleted the use-core-pool-size-1-for-mux-session-maintainer branch 
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 16, 2024
🤖 I have created a release *beep* *boop* --- ## [6.74.1](https://togithub.com/googleapis/java-spanner/compare/v6.74.0...v6.74.1) (2024-09-16) ### Bug Fixes * Use core pool size 1 for maintainer ([#3314](https://togithub.com/googleapis/java-spanner/issues/3314)) ([cce008d](https://togithub.com/googleapis/java-spanner/commit/cce008d212535d32da990242973f7f517ca5d6dc)) ### Dependencies * Update dependency com.google.cloud:sdk-platform-java-config to v3.35.0 ([#3329](https://togithub.com/googleapis/java-spanner/issues/3329)) ([654835f](https://togithub.com/googleapis/java-spanner/commit/654835f2433b97665c74be9ec80c169ac905a720)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
lqiu96 pushed a commit that referenced this pull request Sep 19, 2024
The multiplexed session maintainer used a ScheduledExecutorService with a core pool size of zero. This can cause high CPU usage on Java 8 due to https://bugs.openjdk.org/browse/JDK-8129861. Also on higher versions of Java, it is better to use an executor with at least one core thread, instead of letting the executor create a new thread every time a task needs to be executed. Fixes #3313 Fixes https://togithub.com/GoogleCloudPlatform/pgadapter/issues/2249 Fixes https://togithub.com/googleapis/java-spanner-jdbc/issues/1736
lqiu96 pushed a commit that referenced this pull request Sep 19, 2024
🤖 I have created a release *beep* *boop* --- ## [6.74.1](https://togithub.com/googleapis/java-spanner/compare/v6.74.0...v6.74.1) (2024-09-16) ### Bug Fixes * Use core pool size 1 for maintainer ([#3314](https://togithub.com/googleapis/java-spanner/issues/3314)) ([cce008d](https://togithub.com/googleapis/java-spanner/commit/cce008d212535d32da990242973f7f517ca5d6dc)) ### Dependencies * Update dependency com.google.cloud:sdk-platform-java-config to v3.35.0 ([#3329](https://togithub.com/googleapis/java-spanner/issues/3329)) ([654835f](https://togithub.com/googleapis/java-spanner/commit/654835f2433b97665c74be9ec80c169ac905a720)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The multiplexed session maintainer used a ScheduledExecutorService with a core pool size of zero. This can cause high CPU usage on Java 8 due to https://bugs.openjdk.org/browse/JDK-8129861. Also on higher versions of Java, it is better to use an executor with at least one core thread, instead of letting the executor create a new thread every time a task needs to be executed.
Fixes #3313
Fixes GoogleCloudPlatform/pgadapter#2249
Fixes googleapis/java-spanner-jdbc#1736