chore: Support PG Dialect in Hibernate #2238
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: s 
olavloite reviewed Oct 7, 2025
Comment on lines 31 to 44
| CASE | ||
| WHEN spanner_type LIKE 'character varying[]' then '_varchar' | ||
| ELSE DATA_TYPE | ||
| END AS "TYPE_NAME", |
There was a problem hiding this comment.
I think that we should keep this consistent for all data types, and not only for varchar. And it should preferably align with what the PG JDBC driver returns. My assumption is that it is _varchar, and then also for example _timestamp. But what does it return for for example bigint[] / int8[] / _int8?
There was a problem hiding this comment.
it always returns _bigint in PG dialect.
product-auto-label bot added size: m 
sakthivelmanii changed the title sakthivelmanii force-pushed the support_pg_dialect branch 2 times, most recently from 45c2059 to 02d584b Compare 
sakthivelmanii force-pushed the support_pg_dialect branch from 02d584b to a5a3446 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
character varying[]is actually converted to Postgrestexttype Ref.character varying[]type is not actually returning the type of elements in array which isvarchar. We are exposing the type in TYPE_NAME column. Why are we adding_to the type name? It's because PostgreSQL names array types by prepending an underscore to the base name.typeNamecan be from Postgres dialect equivalent.