- Notifications
You must be signed in to change notification settings - Fork 130
feat: Add BigLakeConfiguration Property in StandardTableDefinition.java #2916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits Select commit Hold shift + click to select a range
e2f5711 Added BigLakeConfiguration in standard table defenition
vteja11 b353bf1 feat: Add BigLakeConfiguration Property in StandardTableDefinition.java
vteja11 c4870e8 Merge branch 'bq-biglake' of https://github.com/vteja11/java-bigquery…
vteja11 bacc82d feat: Update copyright dates to 2023
vteja11 51935be feat: Removed bigstore and gs:/ from docs
vteja11 f5f457d feat: Renamed Biglake to BigLake
vteja11 8ab7599 feat: Adding difference entry to resolve clirr error
vteja11 5cc8650 feat: Refactored formatting to comply with project rules
vteja11 fdd55ef 🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
123 changes: 123 additions & 0 deletions 123 google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigLakeConfiguration.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| /* | ||
| * Copyright 2016 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| | ||
| package com.google.cloud.bigquery; | ||
| | ||
| import com.google.auto.value.AutoValue; | ||
| import java.io.Serializable; | ||
| | ||
| @AutoValue | ||
| public abstract class BigLakeConfiguration implements Serializable { | ||
| | ||
| private static final long serialVersionUID = -5951589238459622025L; | ||
| | ||
| /** | ||
| * Credential reference for accessing external storage system. Normalized as | ||
| * project_id.location_id.connection_id. | ||
| * | ||
| * @return value or {@code null} for none | ||
| */ | ||
| public abstract String getConnectionId(); | ||
| | ||
| /** | ||
| * Open source file format that the table data is stored in. Currently only PARQUET is supported. | ||
| * | ||
| * @return value or {@code null} for none | ||
| */ | ||
| public abstract String getFileFormat(); | ||
| | ||
| /** | ||
| * Fully qualified location prefix of the external folder where data is stored. Normalized to | ||
| * standard format: "gs:/". Starts with "gs://" rather than "/bigstore/". Ends with "/". Does not | ||
vteja11 marked this conversation as resolved. Outdated Show resolved Hide resolved | ||
| * contain "*". See also BigLakeStorageMetadata on how it is used. | ||
| * | ||
| * @return value or {@code null} for none | ||
| */ | ||
| public abstract String getStorageUri(); | ||
| | ||
| /** | ||
| * Open source file format that the table data is stored in. Currently only PARQUET is supported. | ||
| * | ||
| * @return value or {@code null} for none | ||
| */ | ||
| public abstract String getTableFormat(); | ||
| | ||
| public static Builder newBuilder() { | ||
| return new AutoValue_BigLakeConfiguration.Builder(); | ||
| } | ||
| | ||
| public abstract Builder toBuilder(); | ||
| | ||
| @AutoValue.Builder | ||
| public abstract static class Builder { | ||
| /** | ||
| * [Required] Required and immutable. Credential reference for accessing external storage | ||
| * system. Normalized as project_id.location_id.connection_id. | ||
| * | ||
| * @param connectionId connectionId or {@code null} for none | ||
| */ | ||
| public abstract Builder setConnectionId(String connectionId); | ||
| | ||
| /** | ||
| * [Required] Required and immutable. Open source file format that the table data is stored in. | ||
| * Currently only PARQUET is supported. | ||
| * | ||
| * @param fileFormat fileFormat or {@code null} for none | ||
| */ | ||
| public abstract Builder setFileFormat(String fileFormat); | ||
| | ||
| /** | ||
| * [Required] Required and immutable. Fully qualified location prefix of the external folder | ||
| * where data is stored. Normalized to standard format: "gs:/". Starts with "gs://" rather than | ||
vteja11 marked this conversation as resolved. Outdated Show resolved Hide resolved | ||
| * "/bigstore/". Ends with "/". Does not contain "*". See also BigLakeStorageMetadata on how it | ||
vteja11 marked this conversation as resolved. Outdated Show resolved Hide resolved | ||
| * is used. | ||
| * | ||
| * @param storageUri storageUri or {@code null} for none | ||
| */ | ||
| public abstract Builder setStorageUri(String storageUri); | ||
| | ||
| /** | ||
| * [Required] Required and immutable. Open source file format that the table data is stored in. | ||
| * Currently only PARQUET is supported. | ||
| * | ||
| * @param tableFormat tableFormat or {@code null} for none | ||
| */ | ||
| public abstract Builder setTableFormat(String tableFormat); | ||
| | ||
| public abstract BigLakeConfiguration build(); | ||
| } | ||
| | ||
| com.google.api.services.bigquery.model.BigLakeConfiguration toPb() { | ||
| com.google.api.services.bigquery.model.BigLakeConfiguration biglakeConfiguration = | ||
| new com.google.api.services.bigquery.model.BigLakeConfiguration(); | ||
| biglakeConfiguration.setConnectionId(getConnectionId()); | ||
| biglakeConfiguration.setFileFormat(getFileFormat()); | ||
| biglakeConfiguration.setStorageUri(getStorageUri()); | ||
| biglakeConfiguration.setTableFormat(getTableFormat()); | ||
| | ||
| return biglakeConfiguration; | ||
| } | ||
| | ||
| static BigLakeConfiguration fromPb( | ||
| com.google.api.services.bigquery.model.BigLakeConfiguration biglakeConfigurationPb) { | ||
| return newBuilder() | ||
| .setConnectionId(biglakeConfigurationPb.getConnectionId()) | ||
| .setFileFormat(biglakeConfigurationPb.getFileFormat()) | ||
| .setStorageUri(biglakeConfigurationPb.getStorageUri()) | ||
| .setTableFormat(biglakeConfigurationPb.getTableFormat()) | ||
| .build(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions 80 google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/BigLakeConfigurationTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| /* | ||
| * Copyright 2016 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| | ||
| package com.google.cloud.bigquery; | ||
| | ||
| import static org.junit.Assert.assertEquals; | ||
| | ||
| import org.junit.Test; | ||
| | ||
| public class BigLakeConfigurationTest { | ||
| | ||
| private static final String STORAGE_URI = "gs://storage-uri"; | ||
| private static final String FILE_FORMAT = "PARQUET"; | ||
| private static final String TABLE_FORMAT = "ICEBERG"; | ||
| private static final String CONNECTION_ID = "us.test-connection"; | ||
| | ||
| private static final BigLakeConfiguration BIG_LAKE_CONFIGURATION = | ||
| BigLakeConfiguration.newBuilder() | ||
| .setStorageUri(STORAGE_URI) | ||
| .setFileFormat(FILE_FORMAT) | ||
| .setTableFormat(TABLE_FORMAT) | ||
| .setConnectionId(CONNECTION_ID) | ||
| .build(); | ||
| private static final com.google.api.services.bigquery.model.BigLakeConfiguration | ||
| BIG_LAKE_CONFIGURATION_PB = | ||
| new com.google.api.services.bigquery.model.BigLakeConfiguration() | ||
| .setStorageUri(STORAGE_URI) | ||
| .setFileFormat(FILE_FORMAT) | ||
| .setTableFormat(TABLE_FORMAT) | ||
| .setConnectionId(CONNECTION_ID); | ||
| | ||
| @Test | ||
| public void testToBuilder() { | ||
| assertEquals(STORAGE_URI, BIG_LAKE_CONFIGURATION.getStorageUri()); | ||
| assertEquals(FILE_FORMAT, BIG_LAKE_CONFIGURATION.getFileFormat()); | ||
| assertEquals(TABLE_FORMAT, BIG_LAKE_CONFIGURATION.getTableFormat()); | ||
| assertEquals(CONNECTION_ID, BIG_LAKE_CONFIGURATION.getConnectionId()); | ||
| } | ||
| | ||
| @Test | ||
| public void testToPb() { | ||
| assertBigLakeConfiguration(BIG_LAKE_CONFIGURATION_PB, BIG_LAKE_CONFIGURATION.toPb()); | ||
| } | ||
| | ||
| @Test | ||
| public void testFromPb() { | ||
| assertBigLakeConfiguration( | ||
| BIG_LAKE_CONFIGURATION, BigLakeConfiguration.fromPb(BIG_LAKE_CONFIGURATION_PB)); | ||
| } | ||
| | ||
| private static void assertBigLakeConfiguration( | ||
| BigLakeConfiguration expected, BigLakeConfiguration actual) { | ||
| assertEquals(expected.getConnectionId(), actual.getConnectionId()); | ||
| assertEquals(expected.getTableFormat(), actual.getTableFormat()); | ||
| assertEquals(expected.getStorageUri(), actual.getStorageUri()); | ||
| assertEquals(expected.getFileFormat(), actual.getFileFormat()); | ||
| } | ||
| | ||
| private static void assertBigLakeConfiguration( | ||
| com.google.api.services.bigquery.model.BigLakeConfiguration expected, | ||
| com.google.api.services.bigquery.model.BigLakeConfiguration actual) { | ||
| assertEquals(expected.getConnectionId(), actual.getConnectionId()); | ||
| assertEquals(expected.getTableFormat(), actual.getTableFormat()); | ||
| assertEquals(expected.getStorageUri(), actual.getStorageUri()); | ||
| assertEquals(expected.getFileFormat(), actual.getFileFormat()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: copyright dates