MediaIoBaseDownload: Handle unknown media length #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
googlebot added the cla: yes 
danielx changed the title Some media download APIs does not support partial downloads and do not return a 'Content-length' or 'Content-range' header and is therefore never considered done. This change is to consider responses where the media length is unknown to be done. This commit could potentially break media downloads where the API supports partial download and only returns a 'Content-length' header when the entire file has been served/read. This commit fixes issue #15
| How is this a fix? Doesn't it mean that if I rely on the |
| @YBadiss only if the server does not respond with a |
theacodes approved these changes Jan 16, 2018
| Thanks, @danielx! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Some media download APIs does not support partial downloads and do not return a 'Content-length' or 'Content-range' header and is therefore never considered done.
This change is to consider responses where the media length is unknown to be done.
This commit could potentially break media downloads where the API supports partial download and only returns a 'Content-length' header when the entire file has been served/read.
This commit fixes issue #15