net: filter GetAddr netlink requests by interface index #75076
+90 −1
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #53660.
This Linux-specific optimization adds filtering by network interface index to the
RTM_GETADDR
netlink dump request, by setting theNETLINK_GET_STRICT_CHK
socket option to enable strict checking and setting theIfAddrmsg.Index
field to the requested interface index. This eliminates theO(n^2)
behavior described in the issue, resulting in a significant performance improvement on systems with a large number (thousands) of network interfaces:This PR does not require any changes to the public API. In order to avoid changes to the (frozen)
syscall.NetlinkRIB
API (which hard-codes its netlink requests to the olderRtGenmsg
type), this PR copies this logic into an unexportednetlinkRIB
function with the necessary changes to send the new message type.