Skip to content

Conversation

@perazz
Copy link
Member

@perazz perazz commented Mar 7, 2025

Standardize the null_device function (previously in the subprocess submodule).

This PR aims to provide a standard cross-platform reference to the null device file name.

  • uses a macro-based C static interface for zero overhead
  • Add test and examples

cc: @jvdp1 @jalvesz

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @perazz

@perazz
Copy link
Member Author

perazz commented Mar 9, 2025

Thank you @jvdp1! Let us wait another day or two for comments. Then, I think we can merge this simple PR.

Copy link
Contributor

@jalvesz jalvesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @perazz, thanks for this PR!

@perazz
Copy link
Member Author

perazz commented Mar 10, 2025

Thank you @jvdp1 @jalvesz, I will merge this PR.

@perazz perazz merged commit 954a84b into fortran-lang:master Mar 10, 2025
14 checks passed
@perazz perazz deleted the os_null_device branch March 10, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants