Skip to content

Conversation

@zulinx86
Copy link
Contributor

@zulinx86 zulinx86 commented Dec 4, 2025

Changes

This reverts commit 22b6680.

Reason

It turned out the vmap()-based approach doesn't work with UFFD properly because it doesn't use the userspace mapping.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.
This reverts commit 22b6680. It turned out the vmap()-based approach doesn't work with UFFD properly because it doesn't use the userspace mapping. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
@zulinx86 zulinx86 enabled auto-merge (rebase) December 4, 2025 15:30
@zulinx86 zulinx86 merged commit 1b81e76 into firecracker-microvm:feature/secret-hiding Dec 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants