Hotplug Integration Tests #4704
Open
+146 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Will the hotplug features possibly land in 1.9? |
Contributor
Hi @kanpov, thanks for your interest in the vcpu hotplugging feature! |
roypat previously approved these changes Aug 1, 2024
ghost force-pushed the hotplug-integration-tests branch from 3af1fc3 to aced9b1 Compare 
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## feature/vcpu-hotplug #4704 +/- ## ===================================================== Coverage 81.95% 81.95% ===================================================== Files 257 257 Lines 31762 31762 ===================================================== Hits 26031 26031 Misses 5731 5731
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ghost force-pushed the hotplug-integration-tests branch 2 times, most recently from 8da1a8f to 0ba64b9 Compare 
roypat force-pushed the feature/vcpu-hotplug branch from a8819ed to 4faee33 Compare ghost force-pushed the hotplug-integration-tests branch 3 times, most recently from fcc2f79 to 2ff7b52 Compare ghost marked this pull request as ready for review 
Extend the python test API to include the hotplug endpoint. Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
ghost force-pushed the hotplug-integration-tests branch 5 times, most recently from bb2d108 to 08a69a8 Compare Create some functional integration tests for hotplugging. Covering positive and negative cases, as well as onlining of vCPUs Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
ghost force-pushed the hotplug-integration-tests branch from 08a69a8 to f050f98 Compare 
ghost added the Status: Awaiting review roypat approved these changes Aug 27, 2024
Manciukic added the Status: Parked 
JamesC1305 removed the Status: Awaiting review Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changes
Add functional integration tests for vCPU hot-plugging
Reason
To ensure that everything works as intended
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.