Added URL Shortener sample #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Thanks for the sample @Ulydev , Sorry for not reviewing it right now as I'm cranking on some stuff for Google IO. I'll review as soon as I can find some time :) |
nicolasgarnier suggested changes May 31, 2017
url-shortener/functions/index.js Outdated
| function createShortenerPromise(snapshot) { | ||
| const key = snapshot.key; | ||
| const originalUrl = snapshot.val(); | ||
| return request(createShortenerRequest(originalUrl)).then( |
Contributor
There was a problem hiding this comment.
I kind of prefer it this way, i.e. make the Promise return the shortURL then use it inside another then().
return request(createShortenerRequest(originalUrl)).then(response => { if (response.statusCode === 200) { return response.body.id; } throw response.body; }).then(shortUrl => { return admin.database().ref(`/links/${key}`).set({ original: originalUrl, short: shortUrl }); });
Contributor Author
| There you go! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello,
Here's a sample cloud function I'm using in my project. Thought I'd share it 😃
It replaces new links with shorter URLs generated with the Google URL Shortener API.