added support for automl-models #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hiranya911 suggested changes Mar 24, 2020
Contributor
hiranya911 left a comment
hiranya911 left a comment There was a problem hiding this comment.
Looks good in general. Just a few comments on readability.
hiranya911 approved these changes Mar 26, 2020
Contributor
hiranya911 left a comment
hiranya911 left a comment There was a problem hiding this comment.
LGTM with a couple of suggestions.
firebase_admin/ml.py Outdated
| model_source = None | ||
| gcs_tflite_uri = data.pop('gcsTfliteUri', None) | ||
| if gcs_tflite_uri: | ||
| model_source = TFLiteGCSModelSource(gcs_tflite_uri=gcs_tflite_uri) |
firebase_admin/ml.py Outdated
| model_source = TFLiteGCSModelSource(gcs_tflite_uri=gcs_tflite_uri) | ||
| auto_ml_model = data.pop('automlModel', None) | ||
| if auto_ml_model: | ||
| model_source = TFLiteAutoMlSource(auto_ml_model=auto_ml_model) |
firebase_admin/ml.py Outdated
| def __eq__(self, other): | ||
| if isinstance(other, self.__class__): | ||
| return self._auto_ml_model == other._auto_ml_model # pylint: disable=protected-access | ||
| return self._auto_ml_model == other.auto_ml_model |
Contributor
There was a problem hiding this comment.
Suggested change
| return self._auto_ml_model == other.auto_ml_model | |
| return self.auto_ml_model == other.auto_ml_model |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
added support for automl-models