Skip to content

Conversation

kimkit
Copy link
Contributor

@kimkit kimkit commented Aug 28, 2025

Description

before
image

after
image

Additional Information

Checklist

Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • I am aware the project is currently in maintenance-only mode. See README
  • I am aware that translations MUST be made through Transifex and that this PR is NOT a translation update
  • I am making a PR against the master branch.
  • I am sure File Browser can be successfully built. See builds and development.
@kimkit kimkit requested review from hacdias and o1egl as code owners August 28, 2025 12:39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s no need to set the height, since it’s already constrained by the parent container. Instead, let’s use:

.md_preview { padding: 1rem; border: 1px solid #000; font-size: 20px; line-height: 1.2; } #preview-container { overflow: auto; flex: 1; }

Could you also remove all wheel event listeners from the Editor.vue? That way the browser can handle the scroll, making it smoother.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have remove unused style. But I cannot use wheel when removing wheel event listeners.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you also removed the @wheel.prevent.stop directive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok now.

Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hacdias hacdias merged commit 783503a into filebrowser:master Sep 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants