Skip to content

Conversation

@ulgens
Copy link
Contributor

@ulgens ulgens commented Nov 2, 2025

It was defined in testenv.deps for tox, making it a literal testing requirement. The version requirement is copied from pyproject.toml.

This change helps with the local testing, in a similar way to #9817 does. Because setuptools dependency was only defined for tox, the recommended testing method in https://www.django-rest-framework.org/community/contributing/#testing

# Setup the virtual environment python3 -m venv env source env/bin/activate pip install -e . pip install -r requirements.txt # Run the tests ./runtests.py 

were skipping coreapi related tests.

@ulgens ulgens force-pushed the move-setuptools-testing-requirements branch from f55e8b9 to 1a88ae5 Compare November 2, 2025 11:53
It was defined in `testenv.deps` for tox, making it a literal testing requirement. The version requirement is copied from `pyproject.toml`.
@ulgens ulgens force-pushed the move-setuptools-testing-requirements branch from 1a88ae5 to c096d18 Compare November 2, 2025 12:02
@auvipy auvipy requested a review from browniebroke November 2, 2025 12:12
@browniebroke
Copy link
Collaborator

Do we need it at all? I would have thought we could remove it entirely but maybe it's needed by one of our deps?

@browniebroke
Copy link
Collaborator

Tests seems to pass without it, so I'm pretty sure we no longer meed it (I'm assuming since #9056). It's also added to GitHub actions here:

run: python -m pip install --upgrade pip setuptools virtualenv wheel

Can we remove it from all these places, please?

@ulgens
Copy link
Contributor Author

ulgens commented Nov 4, 2025

Tests seems to pass without it

It causes 61 tests to skip tho. I'll revisit this when I have the time, probably on the weekend.

@browniebroke
Copy link
Collaborator

it causes 61 tests to skip tho

Oh I missed that. I thought they were skipped purely because of the other missing dependency.

Copy link
Collaborator

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good to me

@browniebroke browniebroke merged commit 2465f9b into encode:main Nov 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants