Changes to usage of DrupalFinderComposerRuntime API in ScriptHandler #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Add sanity null-check for $drupalRoot - Restore Path generator for config_sync_directory
AlexSkrypnyk reviewed Jul 2, 2024
AlexSkrypnyk requested changes Jul 2, 2024
Collaborator
AlexSkrypnyk left a comment
AlexSkrypnyk left a comment There was a problem hiding this comment.
@jnoordsij
Thank you for your contribution!
I think this looks good. Could you please update the code to follow the code style used in the current file.
AlexSkrypnyk added the PR: Requires more work Co-authored-by: Alex Skrypnyk <alex@drevops.com>
jnoordsij force-pushed the improve-drupal-finder-api branch from bbe78b0 to 3f0ee07 Compare 
Member
| 👍 |
normanlolx approved these changes Jul 2, 2024
Collaborator
| Glad to see this sorted out dynamically. 🤩 |
AlexSkrypnyk approved these changes Jul 3, 2024
AlexSkrypnyk added a commit that referenced this pull request Jul 19, 2024
…677) Co-authored-by: Alex Skrypnyk <alex@drevops.com>
AlexSkrypnyk added a commit that referenced this pull request Jul 19, 2024
…677) Co-authored-by: Alex Skrypnyk <alex@drevops.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
$drupalRootPathgenerator forconfig_sync_directoryThis is a rebased version of #650 that reverts some changes introduced in #673.
Hopefully due to the changes introduced in webflo/drupal-finder#73 and the subsequent release (https://github.com/webflo/drupal-finder/releases/tag/1.3.1), the CI should now pass without manual overriding of the config sync directory.
This probably solves #675.
Note: if preferable, I could update
composer.jsonto explicitly require"webflo/drupal-finder": "^1.3.1".