GroupBy support #31
Merged
GroupBy support #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
xdev-developer force-pushed the group-by branch from a6adf7f to 58e1432 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #31 +/- ## ============================================ + Coverage 65.68% 66.68% +1.00% - Complexity 585 600 +15 ============================================ Files 105 107 +2 Lines 2066 2095 +29 Branches 173 176 +3 ============================================ + Hits 1357 1397 +40 + Misses 611 598 -13 - Partials 98 100 +2
Continue to review full report at Codecov.
|
dengliming requested changes Dec 20, 2021
...imeseries/src/main/java/io/github/dengliming/redismodule/redistimeseries/GroupByOptions.java Outdated Show resolved Hide resolved
redistimeseries/src/main/java/io/github/dengliming/redismodule/redistimeseries/Reducer.java Outdated Show resolved Hide resolved
| assertThat(end.get(1).getValue()).isEqualTo(10.0d); | ||
| } | ||
| | ||
| @Ignore("Only for redis timeseries >= 1.6.0") |
Owner
There was a problem hiding this comment.
Can we open it for this PR? The timeseries version of ci is the lastest. So we can keep it open.
Contributor Author
There was a problem hiding this comment.
latest release in redislabs is 1.14.3, you can use redislabs/redistimeseries:1.6.0 and test should pass :)
xdev-developer force-pushed the group-by branch from 58e1432 to e2b1aa4 Compare xdev-developer force-pushed the group-by branch from ba54ba5 to 6d047da Compare 
dengliming approved these changes Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #15