Skip to content

Add atan2 specification #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2020
Merged

Add atan2 specification #47

merged 1 commit into from
Sep 28, 2020

Conversation

@kgryte
Copy link
Contributor

@kgryte kgryte commented Sep 21, 2020 •
edited
Loading

This PR

  • adds a specification for atan2, which is universally implemented across array libraries.
  • follows the conventions set forth for element-wise mathematical functions.
rgommers
rgommers approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte
@rgommers rgommers merged commit ac383ed into master Sep 28, 2020
@rgommers rgommers deleted the atan2 branch September 28, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@kgryte @rgommers