BUG: torch: fix count_nonzero with axis tuple and keepdims #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Ran locally (yes, |
ev-br commented May 9, 2025
ev-br commented May 11, 2025
ev-br commented May 11, 2025
ev-br commented May 11, 2025
ev-br force-pushed the count_nonzero_torch_tuple_axis_ branch from 60f9310 to 8c62443 Compare | CI is green despite numpy 1.22 nonsense; real testing has been done locally (#318 (comment)), including the matching test from |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
closes #311
A matching test is at data-apis/array-api-tests#372
I checked locally that the fix seems to work, but still the sequence is to merge data-apis/array-api-tests#372 and rerun the CI here.