Skip to content

Conversation

@tenhobi
Copy link
Contributor

@tenhobi tenhobi commented Sep 2, 2024

Adds option to use Remove this widget also on Sliver widgets (with sliver and slivers argument).
Fixes #56637

Also adds ability to remove widget without child/children/sliver/slivers/builder arguments, if the widget is in a list.
Fixes #56390


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
@tenhobi tenhobi changed the base branch from main to master September 2, 2024 21:42
@copybara-service
Copy link

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/383201

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

2 similar comments
@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

2 similar comments
@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request.

@copybara-service copybara-service bot closed this in 1846698 Sep 5, 2024
@JulianHock
Copy link

JulianHock commented Sep 6, 2024

Great job @tenhobi ! Do you have an idea how long it will take to have this in "stable"?

@tenhobi
Copy link
Contributor Author

tenhobi commented Sep 6, 2024

@JulianHock no idea. I suppose next Dart release should have this included? But I am really not sure how these things work tbo. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants