- Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: make remove widget work for slivers #56638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make remove widget work for slivers #56638
Conversation
| Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/383201 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
1 similar comment
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
1 similar comment
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
2 similar comments
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
2 similar comments
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
1 similar comment
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
1 similar comment
| https://dart-review.googlesource.com/c/sdk/+/383201 has been updated with the latest commits from this pull request. |
| Great job @tenhobi ! Do you have an idea how long it will take to have this in "stable"? |
| @JulianHock no idea. I suppose next Dart release should have this included? But I am really not sure how these things work tbo. 😁 |
Adds option to use
Remove this widgetalso on Sliver widgets (withsliverandsliversargument).Fixes #56637
Also adds ability to remove widget without
child/children/sliver/slivers/builderarguments, if the widget is in a list.Fixes #56390