Skip to content

Conversation

@Tienisto
Copy link
Contributor

@Tienisto Tienisto commented Nov 5, 2023

The returned future comes from the _ensureDoneFuture helper function which always returns Future<void>. Making the return type more specific should not be a breaking change because the changed classes are
private.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Contributions to our repos should follow the Dart style guide and use dart format.

Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.

@copybara-service
Copy link

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/334121

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

@lrhn
Copy link
Member

lrhn commented Nov 6, 2023

I'd love to land this, but it is a potentially breaking change, which is why we haven't just fixed it already.

Let's see if it breaks anything this time.

@mraleph
Copy link
Member

mraleph commented Nov 20, 2023

@lrhn friendly ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants