Skip to content

feat: Migrate from rust-s3 fork to official AWS SDK for Rust #10269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stevendotdelahunty wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Migrate from rust-s3 fork to official AWS SDK for Rust #10269

stevendotdelahunty wants to merge 1 commit into from
+166 −173

Conversation

@stevendotdelahunty
Copy link

@stevendotdelahunty stevendotdelahunty commented Dec 18, 2025

  • Replace rust-s3 fork dependency with aws-config and aws-sdk-s3
  • Refactor S3RemoteFs to use AWS SDK client instead of Bucket wrapper
  • Remove manual credential refresh loop - AWS SDK handles automatically
  • Update all S3 operations: put_object, get_object, delete_object, list_objects_v2
  • Simplify credential chain by leveraging AWS SDK's built-in providers
  • No breaking changes to RemoteFs and ExtendedRemoteFs interfaces

Benefits:

  • Removes fork maintenance burden
  • Better automatic credential handling
  • Cleaner, more maintainable code
  • Uses officially maintained library

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required
@stevendotdelahunty
feat: Migrate from rust-s3 fork to official AWS SDK for Rust
a26a051 
- Replace rust-s3 fork dependency with aws-config and aws-sdk-s3 - Refactor S3RemoteFs to use AWS SDK client instead of Bucket wrapper - Remove manual credential refresh loop - AWS SDK handles automatically - Update all S3 operations: put_object, get_object, delete_object, list_objects_v2 - Simplify credential chain by leveraging AWS SDK's built-in providers - No breaking changes to RemoteFs and ExtendedRemoteFs interfaces Benefits: - Removes fork maintenance burden - Better automatic credential handling - Cleaner, more maintainable code - Uses officially maintained library
@stevendotdelahunty stevendotdelahunty requested a review from a team as a code owner December 18, 2025 14:22
@github-actions github-actions bot added cube store Issues relating to Cube Store rust Pull requests that update Rust code pr:community Contribution from Cube.js community members. labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cube store Issues relating to Cube Store pr:community Contribution from Cube.js community members. rust Pull requests that update Rust code

1 participant

@stevendotdelahunty