Skip to content

Conversation

@pe8ter
Copy link

@pe8ter pe8ter commented Nov 2, 2021

For the time being, this PR is here for support.

This PR is an attempt to reinstate browser-support-map-support.js back into this fork. Since this library overrides attempts to load the upstream version of the source-map-support library, consumers are broken because they rely on the existence of this file. We would like this fork to include this file once again.

Here you can see that there are several instances of this fork assuming the execution context is Node.js. There must be checks for the browser to stop this assumption.

Although there are no errors within in this library in particular, the dependency @cspotcode/soure-map-consumer still makes this assumption, particularly here.

Other things missing:

  • This PR does not minify the built library because the minified file comes back from the Google service as nearly empty.
  • No attempts to fix the various tests has been made. They are still broken.
@pe8ter
Copy link
Author

pe8ter commented Nov 22, 2021

I cannot commit to working on this. In the meantime, I'll convert my Karma config back to plain JavaScript so that ts-node does not impede loading the upstream version of this library.

@pe8ter pe8ter closed this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant