3.2 C downloads #1022
Merged
3.2 C downloads #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Couchbase Lite C downloads page to use a more maintainable template-based approach instead of hardcoded version-specific content. The change consolidates multiple manually maintained release sections into a streamlined system using parameterized includes.
- Replaces thousands of lines of hardcoded download tables with parameterized template includes
- Updates template partial to use standard AsciiDoc
[tabs]syntax instead of variable substitution - Adds Vector Search 1.0.0 downloads using the same template system
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/c/pages/gs-downloads.adoc | Removes hardcoded download tables for versions 3.2.4, 3.2.3, and 3.2.2; replaces with parameterized includes for easier maintenance |
| modules/c/pages/_partials/downloadslist.adoc | Fixes AsciiDoc syntax by removing variable substitution in [tabs] directives |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| [#tbl-downloads-{our-version}] | ||
| .Download link table | ||
| [{tabs}] | ||
| [tabs] |
There was a problem hiding this comment.
The change from [{tabs}] to [tabs] is correct. AsciiDoc [tabs] is a standard directive and should not use variable substitution. This improves maintainability by removing unnecessary complexity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.