This repository was archived by the owner on Nov 16, 2018. It is now read-only.
update readme #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
codeBelt reviewed Jul 26, 2017
README.md Outdated
| ### Tasks | ||
| ## dev tasks | ||
| - $ `yarn dev` (local development) |
There was a problem hiding this comment.
Should probably say (local development with hapi server)
codeBelt reviewed Jul 26, 2017
README.md Outdated
| | ||
| `yarn build` (Production) or with server `yarn start` | ||
| ## build tasks | ||
| - $ `yarn start` (hapi server) |
There was a problem hiding this comment.
should probably say (production build with hapi server)
codeBelt reviewed Jul 26, 2017
README.md Outdated
| | ||
| Never do `yarn clean`. | ||
| ## get started | ||
| 1. Clone this repo |
codeBelt reviewed Jul 26, 2017
README.md Outdated
| 2. $ `yarn` | ||
| 3. $ `yarn dev` | ||
| 4. http://localhost:3000 | ||
| 5. Open your browser's console to see the HMR logs |
There was a problem hiding this comment.
Do we need to tell the person this?
There was a problem hiding this comment.
Yeah, it's the whole point of this example
codeBelt reviewed Jul 26, 2017
README.md Outdated
| 5. Open your browser's console to see the HMR logs | ||
| 6. Modify any files in `src` | ||
| 7. ??? | ||
| 8. In your shell, watch webpack rebuild the example application |
There was a problem hiding this comment.
Do we need to tell the person this?
codeBelt reviewed Jul 26, 2017
README.md Outdated
| 6. Modify any files in `src` | ||
| 7. ??? | ||
| 8. In your shell, watch webpack rebuild the example application | ||
| 9. In your browser's console, watch webpack rebuild and update modules |
There was a problem hiding this comment.
Do we need to tell the person this?
codeBelt reviewed Jul 26, 2017
README.md Outdated
| @@ -1,9 +1,22 @@ | |||
| # hapi-react-hot-loader (Work In Progress) | |||
| # `hapi-react-hot-loader` | |||
| Example application demonstrating hot-module-reloading with webpack2, react and friends, and hapi. | |||
There was a problem hiding this comment.
should say "hot-module-reloading 3"
update the readme update
Update README.md
Repository owner deleted a comment from ccheney Jul 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
☀️