Skip to content

Conversation

ondratra
Copy link
Contributor

This merge adds new flag optional to PropertyDeclaration.
It is true for TS properties defined optional e.g. { myProperty?: string }

@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

Merging #80 into develop will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@ Coverage Diff @@ ## develop #80 +/- ## =========================================== + Coverage 90.22% 90.23% +0.01%  =========================================== Files 63 63 Lines 972 973 +1 Branches 192 172 -20 =========================================== + Hits 877 878 +1  Misses 88 88 Partials 7 7
Impacted Files Coverage Δ
src/node-parser/interface-parser.ts 92% <ø> (ø) ⬆️
src/node-parser/class-parser.ts 94.36% <ø> (ø) ⬆️
...ators/typescript-generators/propertyDeclaration.ts 60% <0%> (ø) ⬆️
src/declarations/PropertyDeclaration.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 596e150...c2f9efb. Read the comment docs.

@ondratra
Copy link
Contributor Author

I am not sure what caused fail check in CI. @buehler can you please check this pull request and accept it if possible, please? (or tell me what is wrong)

Copy link
Owner

@buehler buehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!
Nice, but there are tests missing ;-) maybe that is why the codecov check fails. Can you add a test for an optional property?

@ondratra
Copy link
Contributor Author

Yes I can :) I am just little bit confused where to put the tests' code. Can you tell me how to create new test in project's structure? (/test folder seems quite complex to me :) )

@buehler
Copy link
Owner

buehler commented Jul 26, 2018

I can and I will, but first I'm gonna finish my holiday :-) I'll be back in 1 week.

@buehler
Copy link
Owner

buehler commented Jul 30, 2018

hmm I could add the PR and add the tests by myself so you get an example. I'll write the reference in this PR as a response for you.

@buehler buehler merged commit 94ea1cc into buehler:develop Jul 30, 2018
@buehler
Copy link
Owner

buehler commented Jul 30, 2018

buehler added a commit that referenced this pull request Jul 31, 2018
 Add tests for isOptional properties and methods (#80) and the same flag to methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants