Updated strstr.cc #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Implemented Rabin-Karp Algorithm for 0028_implement_strstr
Contributor Author
| I have also implemented KMP algorithm for this problem. I was thinking if we should create another file like strstr_kmp.cc and add the implementation there or we can just add it here and comment it out. |
Owner
| You solution is excellent for me. Sorry for my late reply. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The previously implemented method was using an STL function. I have Implemented Rabin-Karp Algorithm which works in O(N). This algorithm is based on the concept of string hashing. More details can be found here