Fix unaligned memory accesses in bitstring #1893
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pguyot force-pushed the w41/fix-bitstring-unaligned-accesses branch from c389673 to cbb0b97 Compare pguyot force-pushed the w41/fix-bitstring-unaligned-accesses branch from cbb0b97 to 107e851 Compare Ensure all unaligned memory accesses are done byte by byte, fixing sigbus on arm Fix usage of __ORDER_LITTLE_ENDIAN__ which is likely to be always defined Add tests for unaligned reads and writes of integers in binaries Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot force-pushed the w41/fix-bitstring-unaligned-accesses branch from 107e851 to dbe4a8a Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See also #1892 which is different
Updated
test_bsdoesn't work until #1895 is mergedThese changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later