This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Expose Node.js Options #1669
Closed
Expose Node.js Options #1669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Added NodeServicesOptions.NodeOptions. - Added "nodeOptions" argument to OutOfProcessNodeInstances constructor. - Updated HttpNodeInstance and SocketNodeInstance (classes that implement OutOfProcessNodeInstance ).
|
|
- Reverted parameter names - Overloaded OutOfProcessNodeInstance's constructor and OutOfProcessNodeInstance.PrepareNodeProcessStartInfo instead of using an optional parameters
JeremyTCD added a commit to JeringTech/Web.SyntaxHighlighters.Prism that referenced this pull request Jun 7, 2018
- Fork allows for debugging js scripts, can use main package if this pull request aspnet/JavaScriptServices#1669 is accepted.
|
|
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@SteveSandersonMS kindly consider.
Goal:
Allow
INodeServicesconsumers to specify Node.js Options such as--inspect-brk. The merits of exposing Node.js options were discussed in these issues:Summary of changes:
I've made some changes that allow for node options to be specified. Backward compatibility has been preserved.
NodeServicesOptions.NodeOptions.nodeOptionsparameter to an overload ofOutOfProcessNodeInstance's constructor.nodeOptionsparameter to an overload ofOutOfProcessNodeInstance.PrepareNodeProcessStartInfo.NodeServicesOptions.NodeOptionstoOutOfProcessNodeInstances's constructor.If these changes are acceptable, I'll update the ReadMe as well. Thanks for considering.