This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Update peerDependency to support webpack 3 #1559
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Update peerDependency to support webpack 3. Reports of various people already running 3.x are listed in #1361. This is only to remove the npm peer dep warning. The issue with webpack 3 was fixed in aspnet-webpack, but this poor soul didn't get a bump.
| Why stop there. Webpack 4 is released now. |
| @GeekyMonkey #1361 Issue was for Webpack3. Mayby you could open an issue for Webpack 4 and PR. We don't have Webpack 4 here so I wouldn't be able to test sorry. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Update peerDependency to support webpack 3.
Addresses #1361