Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Conversation

@stephenlautier
Copy link
Contributor

This fixes middleware when consumers override serializer defaults settings via JsonConvert.DefaultSettings which would break webpack options passed to node.

Since it's expected to be as Pascal case, it's safer to specifically specify it, and in our case we had it default to camelCase which was silently breaking it (and it was quite hard to figure it out).

@dnfclas
Copy link

dnfclas commented Jul 31, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@stephenlautier
Copy link
Contributor Author

If you agree with the PR, can someone look into why the build is failing, as it doesnt look it has to do anything with my changes. Thanks

@SteveSandersonMS SteveSandersonMS merged commit fc12d72 into aspnet:dev Aug 2, 2017
@SteveSandersonMS
Copy link
Member

Thanks @stephenlautier!

Your change looks good. The AppVeyor build fail on the dev branch is a temporary issue until the final ASP.NET Core 2.0 packages are pushed to the public NuGet feed. We have another internal CI system that is still passing, so I know it's still OK.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants