This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Added npm Install on first-run #1107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
on my build agent the build failed because npm install was not running bevor the build. I can not see why npm install should only run when publishing.
| This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
| Maybe it would be useful to run |
| What about the folks using yarn? I could say for myself that I would not be excited if this ran the install for me. I agree with the fact that this isn't much of a time-saver. |
| I close this because it is open for too long and I think this will not be merged. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
on my build agent the build failed because npm install was not running bevor the build. I can not see why npm install should only run when publishing.