This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Fix webpack HMR proxying logic for apps running on non-root URLs (e.g., full IIS virtual directories) #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously the proxying logic handled nonempty
PathBasevalues incorrectly. Also it didn't allow for WebpackpublicPathvalues being set dynamically at runtime via<base href>. Both of these are needed for HMR to work correctly if the app is hosted in a virtual directory.This change, along with an update to the
aspnet-webpackNPM package, will fix #488