Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Conversation

@rosieks
Copy link
Contributor

@rosieks rosieks commented Jun 1, 2017

This is another piece that improves developer experience mentioned in #988. This PR adds source-map support for JavaScript that run on server-side.

@dnfclas
Copy link

dnfclas commented Jun 1, 2017

@rosieks,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Jun 20, 2017

Thanks for the suggestion!

After reading up on https://www.npmjs.com/package/source-map-support, I'm not sure this is an additional dependency that we'd want to enable by default. I appreciate its benefits, but the fact that it changes some default Node behaviours (e.g., around uncaught exceptions) makes it risky. It's the sort of thing that developers can easily add to their own projects if they need it, and then at least they know what they've done and can take responsibility for now having certain nonstandard behaviours. I'm aware of the handleUncaughtExceptions and hookRequire flags but it's yet more concepts for people to make sense of so not ideal to put in by default. TBH I think that source map support is really something that Node itself should be implementing rather than being monkeypatched in at runtime via 3rd-party NPM packages.

Are you OK if we close this?

@rosieks
Copy link
Contributor Author

rosieks commented Jun 20, 2017

Yes, that sounds reasonable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants