Refactor combobox remove redundant elementfinder #9 #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 10 commits August 8, 2019 22:43
…, added verification of wait time
changed IElementStateProvider interface: added methods for waitings with default condition timeouts excluded ability to call state methods directly from elements, now users have to use state() method
refactored elements' states added isClickable
…ity-selenium-java # Conflicts: # src/main/java/aquality/selenium/elements/DesiredState.java # src/main/java/aquality/selenium/elements/Element.java # src/main/java/aquality/selenium/elements/ElementFinder.java # src/main/java/aquality/selenium/elements/ElementStateProvider.java # src/main/java/aquality/selenium/elements/interfaces/IElement.java # src/main/java/aquality/selenium/waitings/ConditionalWait.java # src/test/java/tests/integration/ElementStateTests.java # src/test/java/tests/usecases/ElementExistNotDisplayedTest.java
mialeska approved these changes Aug 22, 2019
aquality-automation pushed a commit that referenced this pull request Aug 24, 2019
* refactored state of elements * re-check waitForNotExists methods for correct work. split 1 test to 2, added verification of wait time * removed IElementWithState interface changed IElementStateProvider interface: added methods for waitings with default condition timeouts excluded ability to call state methods directly from elements, now users have to use state() method * refactored conditional wait refactored elements' states added isClickable * removed redundant ElementFinder usage from getSelectedText() and getValuesList() #9
DmitryBogatko deleted the refactor-combobox-remove-redundant-elementfinder-#9 branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.