Feature/unfocus mouseup #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ity-selenium-java into feature/unfocus-mouseup # Conflicts: # src/main/java/aquality/selenium/elements/Element.java # src/main/java/aquality/selenium/elements/TextBox.java # src/main/java/aquality/selenium/elements/actions/MouseActions.java # src/main/java/aquality/selenium/elements/interfaces/IElement.java # src/main/java/aquality/selenium/elements/interfaces/ITextBox.java
mialeska reviewed Aug 16, 2019
| public void moveMouseFromElement() { | ||
| infoLoc("loc.movingFrom"); | ||
| RemoteWebElement remoteWebElement = element.getElement(); | ||
| ElementActionRetrier.doWithRetry(() -> performAction(((actions, el) -> actions.moveToElement(remoteWebElement, |
There was a problem hiding this comment.
seems that the part of this expression is common and could be moved to a private method (especially ElementActionRetrier.doWithRetry calling
There was a problem hiding this comment.
resolved
mialeska approved these changes Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.