Adding retry policy #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 8 commits August 8, 2019 22:43
…, added verification of wait time
changed IElementStateProvider interface: added methods for waitings with default condition timeouts excluded ability to call state methods directly from elements, now users have to use state() method
refactored elements' states added isClickable
…ity-selenium-java # Conflicts: # src/main/java/aquality/selenium/elements/DesiredState.java # src/main/java/aquality/selenium/elements/Element.java # src/main/java/aquality/selenium/elements/ElementFinder.java # src/main/java/aquality/selenium/elements/ElementStateProvider.java # src/main/java/aquality/selenium/elements/interfaces/IElement.java # src/main/java/aquality/selenium/waitings/ConditionalWait.java # src/test/java/tests/integration/ElementStateTests.java # src/test/java/tests/usecases/ElementExistNotDisplayedTest.java
conditional wait moved under tests/ because of many places where it is used
conditional wait moved under tests/ because of many places where it is used
mialeska requested changes Aug 14, 2019
…g exception if it was failed attempt to select removed catching of WebDriverException in TextBox
| @mialeska changed according to your comments |
paveliam reviewed Aug 14, 2019
mialeska requested changes Aug 14, 2019
| } | ||
| return false; | ||
| if (!isSelected){ | ||
| throw new StaleElementReferenceException(String.format(getLocManager().getValue("loc.combobox.impossible.to.select.contain.value.or.text"), value, getName())); |
There was a problem hiding this comment.
this ain't a real staleElementReference, why should we do retry in this case? let's throw unhandled exception, like we do it in dotnet solution
There was a problem hiding this comment.
replaced
| getElement().clear(); | ||
| getElement().sendKeys(value); | ||
| return true; | ||
| } catch (WebDriverException e) { |
There was a problem hiding this comment.
you should not catch here
| try { | ||
| getElement().sendKeys(value); | ||
| return true; | ||
| } catch (WebDriverException e) { |
There was a problem hiding this comment.
you should not catch here
| infoLoc("loc.clicking"); | ||
| new JsActions(element, type, name).highlightElement(); | ||
| ConditionalWait.waitFor(driver -> performAction(new Actions(driver).click(element.getElement()))); | ||
| ElementActionRetrier.doWithRetry(() -> performAction(new Actions(getBrowser().getDriver()).click(element.getElement()))); |
There was a problem hiding this comment.
seems that it does make sense to make a private method with common logic (please see the dotnet implementation for more details)
mialeska requested changes Aug 14, 2019
| } | ||
| return false; | ||
| if (!isSelected){ | ||
| throw new StaleElementReferenceException(String.format(getLocManager().getValue("loc.combobox.impossible.to.select.contain.value.or.text"), value, getName())); |
| getLogger().debug(e.getMessage()); | ||
| return false; | ||
| } | ||
| ElementActionRetrier.doWithRetry(() -> { |
There was a problem hiding this comment.
we don't need curly braces here
| try { | ||
| getElement().sendKeys(value); | ||
| return true; | ||
| } catch (WebDriverException e) { |
| getElement().clear(); | ||
| getElement().sendKeys(value); | ||
| return true; | ||
| } catch (WebDriverException e) { |
| @@ -1,4 +1,4 @@ | |||
| package aquality.selenium.waitings; | |||
| package utils; | |||
There was a problem hiding this comment.
yes, no longer than today morning I thought we had decided to remove ConditionalWait with its end :) But times are changing
I will get back ConditionalWait in separate PR
| infoLoc("loc.clicking"); | ||
| new JsActions(element, type, name).highlightElement(); | ||
| ConditionalWait.waitFor(driver -> performAction(new Actions(driver).click(element.getElement()))); | ||
| ElementActionRetrier.doWithRetry(() -> performAction(new Actions(getBrowser().getDriver()).click(element.getElement()))); |
paveliam reviewed Aug 14, 2019
| * Click Right (call context menu) on the element | ||
| */ | ||
| public void rightClick() { | ||
| public void clickRight() { |
There was a problem hiding this comment.
I believe it should be named rightClick
There was a problem hiding this comment.
reverted this change
mialeska approved these changes Aug 15, 2019
paveliam approved these changes Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.