Refactoring/safari support #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ity-selenium-java into refactoring/safari-support # Conflicts: # src/test/java/tests/usecases/FileDownloadingTests.java
# Conflicts: # src/test/java/tests/usecases/FileDownloadingTests.java
… refactoring/safari-support # Conflicts: # src/test/java/tests/usecases/FileDownloadingTests.java
aquality-automation assigned mialeska and paveliam and unassigned mialeska and paveliam 
mialeska approved these changes Aug 14, 2019
paveliam reviewed Aug 14, 2019
| */ | ||
| private void setState(boolean state) { | ||
| infoLoc(String.format("%1$s '%2$s'", localizationManager.getValue("loc.setting.value"), state)); | ||
| if (state && !getState()) { |
There was a problem hiding this comment.
Can we user just state != getState() here and simplify it?
There was a problem hiding this comment.
refactored
| private void setState(boolean state) { | ||
| infoLoc(String.format("%1$s '%2$s'", localizationManager.getValue("loc.setting.value"), state)); | ||
| if (state && !getState()) { | ||
| infoLoc(String.format(localizationManager.getValue("loc.checkbox.check"), name, type, true)); |
There was a problem hiding this comment.
The 3rd parameter true/false is redundant
There was a problem hiding this comment.
this logging has been removed
paveliam approved these changes Aug 14, 2019
…t and clickAndSelectByValue methods
…ity-selenium-java into refactoring/safari-support # Conflicts: # src/main/java/aquality/selenium/elements/ComboBox.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.