Include Python version in pip cache key #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
5 tasks
hugovk force-pushed the pip-cache-python-version branch from 6b3d987 to 45cf4cf Compare 
5 tasks
| Hello @hugovk. Thank you for your pull request. Could you please sync with the main branch and run the |
hugovk force-pushed the pip-cache-python-version branch from 45cf4cf to 95b9974 Compare 
| Done! After |
hugovk force-pushed the pip-cache-python-version branch from eba23d0 to 7ccd7e6 Compare | Not sure why these are failing, they pass on my fork: https://github.com/hugovk/setup-python/actions/runs/1643387334 |
| Hello @hugovk. Sorry for the late response. Could please sync with the main branch. Builds should be fixed. |
hugovk force-pushed the pip-cache-python-version branch from 7ccd7e6 to fcd6854 Compare | Rebased and CI passes, thanks! ✅ |
dmitry-shibanov approved these changes Jan 27, 2022
MaksimZhukov approved these changes Jan 27, 2022
| Hello @hugovk! Thank you for the contribution! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description:
Like we do for pipenv, let's include the Python version in the pip cache key.
Without it, PyPy jobs continually build wheels from source, which is slow, and they never make it into the pip cache because there are prebuilt wheels for CPython jobs already in the cache.
Related issue:
Fixes #288.
Fixes #304.
Check list: