update gheatmap to be compatible with ggplot2-4.0.0 #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Open
| } | ||
| | ||
| attr(p2, "mapping") <- mapping | ||
| attr(p2, "data_axis") <- data_axis |
There was a problem hiding this comment.
Is this needed; is this even evaluated in ggplot? Can this line be just removed?
| Hi @GuangchuangYu ! Can this PR be merged as soon as possible? Bioconductor release cycle is approaching and many packages depend on |
| Experiencing the same issue. To what version of R(studio) and/or ggtree and/or Bioconductor should we downgrade in the meantime? |
| My team has been having the same issue as well, advice on what versions to use would be appreciated ~ |
jlingford added a commit to jlingford/ggtree that referenced this pull request Oct 19, 2025
rename "mapping" to "data_axis" to avoid name collisions with new version of ggplot2. Similar issue to YuLab-SMU#666, YuLab-SMU#667, and PR YuLab-SMU#668. Using "data_axis" term to be consistent with commit b6dffa9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix the issue of
gheatmapwith the ggplot2-4.0.0related issues #667, #666