Insertmode performance improvement #9872
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ad of 11) at iteration that happens at base.ts line 267 at time of writting 'for (const actionType of possibleActionsForMode)'. BackspaceInInsertMode was also moved as that has be handled before TypeInInsertMode.
J-Fields reviewed Dec 20, 2025
| } | ||
| } | ||
| | ||
| @RegisterAction |
Member
There was a problem hiding this comment.
Any reason for moving the methods? It makes it more difficult to tell what changed
J-Fields reviewed Dec 20, 2025
| Mode.CommandlineInProgress, | ||
| Mode.SearchInProgressMode, | ||
| ]; | ||
| const literalModesMap = new Map<Mode, boolean>([ |
Member
There was a problem hiding this comment.
Why not use a Set rather than a Map?
J-Fields reviewed Dec 20, 2025
| : -1, | ||
| ); | ||
| const cursorsToIterateOver = | ||
| vimState.cursors.length > 1 |
Member
There was a problem hiding this comment.
Have you measured a performance difference with these changes? I want to be sure we're not prematurely optimizing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a pr to improve "typing while in insert mode" performance.
This is effectively a refactor since that the changes do not introduce any behavioural changes - only increase performance with existing behaviour.
The changes (per the commit messages) do the following:
Which issue(s) this PR fixes
No issues has been created that I know of - I just profiled the "typing while in insertmode" code-path and added low-impact optimizations.
Special notes for your reviewer:
Submitting this to contribute to this great extension and fix issues I experience myself.