Fix: Make start and end macros produce different hashes #4844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MikeWallis42 commented Jun 27, 2025
| def test_pydantic_import_error() -> None: | ||
| class TestConfig(DuckDBConnectionConfig): | ||
| pass | ||
| TestConfig.model_rebuild() |
Contributor Author
There was a problem hiding this comment.
I tried to fix a local issue here but didn't completely fix it.
izeigerman reviewed Jun 27, 2025
| | ||
| start_time, end_time = ( | ||
| make_inclusive(start or c.EPOCH, end or c.EPOCH, self._dialect) | ||
| make_inclusive(start or c.EPOCH, end or c.EPOCH + timedelta(days=1), self._dialect) |
Member
There was a problem hiding this comment.
I don't think this is the only place where we use epoch as a placeholder. I wonder whether we should instead have 3 constants:
START_PLACEHOLDER END_PLACEHOLDER EXECUTION_TIME_PLACEHOLDER and use these instead throughout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #3500
Prior to this, as they have the same default value, if only 1 is used and then changed that would not result in a new data_hash and therefor would not be considered a breaking change when planning.
I'm fully aware that this may need a migration script, please let me know if so as I might need some assistance.