Spiral matrix #13523

SubhadipD9 · 2025-10-16T08:15:41Z

Describe your change:

Add an algorithm?
[ ]

Checklist:

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
All new Python files are placed inside an existing directory.
All filenames are in all lowercase characters with no spaces or dashes.
All functions and variable names follow Python naming conventions.
All function parameters and return values are annotated with Python type hints.
All functions have doctests that pass the automated testing.
All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2025-10-16T08:15:48Z

data_structures/arrays/spiral_matrix.py

@@ -0,0 +1,65 @@
+class Solution:
+ def generateMatrix(self, n: int) -> list[list[int]]:


As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/spiral_matrix.py, please provide doctest for the function generateMatrix

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: generateMatrix

Please provide descriptive name for the parameter: n

algorithms-keeper · 2025-10-16T08:15:48Z

data_structures/arrays/spiral_matrix.py

+ value = 1
+
+ # Define the boundaries for rows and columns
+ rowStart, rowEnd = 0, n - 1


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: rowStart

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: rowEnd

algorithms-keeper · 2025-10-16T08:15:48Z

data_structures/arrays/spiral_matrix.py

+
+ # Define the boundaries for rows and columns
+ rowStart, rowEnd = 0, n - 1
+ colStart, colEnd = 0, n - 1


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: colStart

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: colEnd

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2025-10-16T08:22:25Z

data_structures/arrays/spiral_matrix.py

@@ -0,0 +1,64 @@
+class Solution:
+ def generate_matrix(self, n: int) -> list[list[int]]:


As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/spiral_matrix.py, please provide doctest for the function generate_matrix

Please provide descriptive name for the parameter: n

algorithms-keeper · 2025-10-16T08:22:25Z

data_structures/arrays/spiral_matrix.py

+ value = 1
+
+ # Define the boundaries for rows and columns
+ rowStart, rowEnd = 0, n - 1


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: rowStart

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: rowEnd

algorithms-keeper · 2025-10-16T08:22:25Z

data_structures/arrays/spiral_matrix.py

+
+ # Define the boundaries for rows and columns
+ rowStart, rowEnd = 0, n - 1
+ colStart, colEnd = 0, n - 1


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: colStart

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: colEnd

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2025-10-16T08:31:17Z

data_structures/arrays/spiral_matrix.py

@@ -0,0 +1,65 @@
+class Solution:
+ def generate_matrix(self, n: int) -> list[list[int]]:


As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/spiral_matrix.py, please provide doctest for the function generate_matrix

Please provide descriptive name for the parameter: n

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2025-10-16T08:37:39Z

data_structures/arrays/spiral_matrix.py

@@ -0,0 +1,67 @@
+class Solution:
+ def generate_matrix(self, n: int) -> list[list[int]]:


As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/spiral_matrix.py, please provide doctest for the function generate_matrix

Please provide descriptive name for the parameter: n

for more information, see https://pre-commit.ci

SubhadipD9 added 3 commits October 16, 2025 13:38

Add spiral_matrix implementation

4fe3771

Adding spiral_matrix implemetation and explain it

a387f8e

Adding spiral_matrix code and explanation

bdf0001

algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required labels Oct 16, 2025

algorithms-keeper bot reviewed Oct 16, 2025

View reviewed changes

algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 16, 2025

pre-commit-ci bot and others added 2 commits October 16, 2025 08:17

[pre-commit.ci] auto fixes from pre-commit.com hooks

5ff2bb3

for more information, see https://pre-commit.ci

fixing the code formating mistake and update the code

ff14247

algorithms-keeper bot reviewed Oct 16, 2025

View reviewed changes

pre-commit-ci bot and others added 3 commits October 16, 2025 08:22

[pre-commit.ci] auto fixes from pre-commit.com hooks

f3a3cd9

for more information, see https://pre-commit.ci

fixing naming issue

e6f8b27

del

b4e0e94

algorithms-keeper bot removed require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required labels Oct 16, 2025

Creating code for spiral_matrix DSA problem

0ea4a85

algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required labels Oct 16, 2025

algorithms-keeper bot reviewed Oct 16, 2025

View reviewed changes

pre-commit-ci bot and others added 2 commits October 16, 2025 08:31

[pre-commit.ci] auto fixes from pre-commit.com hooks

05a12dc

for more information, see https://pre-commit.ci

fixing the typo

ff578fb

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 16, 2025

fix the typo

51f3bbb

algorithms-keeper bot reviewed Oct 16, 2025

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

b351094

for more information, see https://pre-commit.ci

algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Spiral matrix #13523

Spiral matrix #13523

Uh oh!

SubhadipD9 commented Oct 16, 2025

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 16, 2025

algorithms-keeper bot Oct 16, 2025

algorithms-keeper bot Oct 16, 2025

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 16, 2025

algorithms-keeper bot Oct 16, 2025

algorithms-keeper bot Oct 16, 2025

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 16, 2025

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 16, 2025

Labels

1 participant

		@@ -0,0 +1,65 @@
		class Solution:
		def generateMatrix(self, n: int) -> list[list[int]]:

		@@ -0,0 +1,64 @@
		class Solution:
		def generate_matrix(self, n: int) -> list[list[int]]:

		@@ -0,0 +1,67 @@
		class Solution:
		def generate_matrix(self, n: int) -> list[list[int]]:

Uh oh!

Spiral matrix #13523

Are you sure you want to change the base?

Spiral matrix #13523

Uh oh!

Conversation

SubhadipD9 commented Oct 16, 2025

Describe your change:

Checklist:

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 16, 2025

Choose a reason for hiding this comment

algorithms-keeper bot Oct 16, 2025

Choose a reason for hiding this comment

algorithms-keeper bot Oct 16, 2025

Choose a reason for hiding this comment

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 16, 2025

Choose a reason for hiding this comment

algorithms-keeper bot Oct 16, 2025

Choose a reason for hiding this comment

algorithms-keeper bot Oct 16, 2025

Choose a reason for hiding this comment

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 16, 2025

Choose a reason for hiding this comment

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 16, 2025

Choose a reason for hiding this comment

Labels

1 participant