Skip to content

Conversation

@vil02
Copy link
Member

@vil02 vil02 commented Mar 15, 2024

Open in Gitpod know more

Describe your change:

This PR removes the duplicated implementation of recursive gcd and moves an iterative one to Maths.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (0204198) to head (71057b1).

Additional details and impacted files
@@ Coverage Diff @@ ## master #1642 +/- ## ========================================== + Coverage 83.92% 84.07% +0.14%  ========================================== Files 376 375 -1 Lines 19698 19688 -10 Branches 2910 2914 +4 ========================================== + Hits 16532 16552 +20  + Misses 3166 3136 -30 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review March 15, 2024 19:57
@raklaptudirm raklaptudirm merged commit bd34e9f into TheAlgorithms:master Mar 16, 2024
@vil02 vil02 deleted the cleanup_gcds branch March 16, 2024 13:10
vil02 added a commit to vil02/JavaScript that referenced this pull request Mar 17, 2024
* feat: remove duplicated `gcd`-like functions * Updated Documentation in README.md --------- Co-authored-by: vil02 <vil02@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants