Skip to content

Conversation

@vil02
Copy link
Member

@vil02 vil02 commented Mar 2, 2024

Open in Gitpod know more

Describe your change:

Similar to #1624 - errors should be thrown not returned. Additionally, this PR reorganizes the tests.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@vil02 vil02 marked this pull request as ready for review March 2, 2024 21:53
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.91%. Comparing base (83b4dd8) to head (e69ee1b).

Additional details and impacted files
@@ Coverage Diff @@ ## master #1628 +/- ## ========================================== + Coverage 83.89% 83.91% +0.02%  ========================================== Files 377 377 Lines 19736 19736 Branches 2916 2919 +3 ========================================== + Hits 16558 16562 +4  + Misses 3178 3174 -4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raklaptudirm raklaptudirm merged commit 2fe0dfd into TheAlgorithms:master Mar 4, 2024
@vil02 vil02 deleted the throw_from_DateToDay branch March 5, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants