Kahn's Algorithm #1480
Open
Kahn's Algorithm #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
appgurueu requested changes Oct 8, 2023
There was a problem hiding this comment.
See my review for cycle.js, essentially the same points apply here. Also, separate the two things. cycle.js does not belong here. Per our naming convention, these file names should not be lowercase. The implementation of Kahn's algorithm given here is also likely needlessly inefficient since queue.shift() is a linear time operation. Try to use one of our linked queues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I have added a javaScript function for detecting cycles in the directed graph which is Kahn's algorithm. Please merge my PR.