Added rectangle area #1246
Closed
Added rectangle area #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
appgurueu reviewed Oct 30, 2022
| return sideA * sideB | ||
| } | ||
| | ||
| export { rectangleArea } |
appgurueu reviewed Oct 30, 2022
| import { rectangleArea } from '../RectangleArea' | ||
| | ||
| describe('RectangleArea', () => { | ||
| it('should return 15', () => { |
Collaborator
There was a problem hiding this comment.
You don't need the it block, just use one test right away
appgurueu reviewed Oct 30, 2022
| @@ -0,0 +1,6 @@ | |||
| const rectangleArea = (sideA, sideB) => { | |||
| // A rectangle's area is calculated by multiplying the 2 sides | |||
| return sideA * sideB | |||
Collaborator
There was a problem hiding this comment.
This might be too trivial to warrant inclusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.