Skip to content

Conversation

@vil02
Copy link
Member

@vil02 vil02 commented May 20, 2024

Closes #453. Uses the same logic as in TheAlgorithms/Java#5100:

  • the tokenless upload is used for PRs from forks,
  • the upload with token is used only for PRs and pushes within this repository.

Similar to TheAlgorithms/Rust#670.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md
@codecov
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.84%. Comparing base (c9e2fa1) to head (8e6da79).
Report is 3 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #454 +/- ## ========================================== - Coverage 94.94% 94.84% -0.10%  ========================================== Files 234 234 Lines 9843 9895 +52 Branches 1382 1393 +11 ========================================== + Hits 9345 9385 +40  - Misses 384 392 +8  - Partials 114 118 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review May 20, 2024 19:56
@vil02 vil02 requested a review from siriak as a code owner May 20, 2024 19:56
@vil02 vil02 force-pushed the use_codecov_token branch from 31cbaaa to 8e6da79 Compare May 20, 2024 19:57
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@siriak siriak merged commit 50829ea into TheAlgorithms:master May 20, 2024
@vil02 vil02 deleted the use_codecov_token branch May 20, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants